All guides

Reviewing the next round

You reviewed a PR and the author pushed. The next round shows what happened since your review, not the whole PR again.

Start the round

When you open a PR again after you submitted a review of it, the Review Room starts the next round. In the Review queue, the row says which round it is.

If the author pushes while the review is open, the Review Room notices. It checks its PRs when it opens, when the window gets focus, and every 3 minutes. A banner then says “This PR has new commits since your review.”

Threads you posted carry into the new round, and so do threads you dismissed, with your reasons. Findings that nobody touched are dropped. Viewed marks carry over for files that didn’t change.

Switch views

The picker in the layer bar switches between Round 2 · since ‹date› (or the round you are in) and All changes, the whole PR. It also lists the PR’s commits, to read one at a time.

The round view follows the stack as PRs merge or are inserted. A PR that left the stack stays as one collapsed line with its drafts. A PR that is new to the stack opens in All changes. After a rebase, it shows only the PR’s own changes.

Your feedback

The round view has three sections. The first is Your feedback: one block for each thing you said last round. That is each comment you posted, your review summary and your PR comments, with the replies to them.

The block’s header says whose turn it is (Your turn or Waiting on the author), whether your lines changed, and how many replies came in. Your turn comes first.

Under your message and the replies, the block shows the changes that answer it. These are the changes at your lines, and the changes the Companion matched to your comment, each with a short note on what it does.

The Companion matches them in the background:

Each matched change has its own Viewed box. If a change doesn’t belong to your comment, mark it Viewed and reply if you need to. It stays under that feedback.

To answer, write in the block: ask the Companion, or draft a reply for GitHub.

When the author has dealt with one of your threads, select Resolve on GitHub. It is queued with your review. The block says Resolves on Submit, with Undo, and SimpleEdit resolves the thread when you submit. If resolving fails, submit again to retry.

Fold a block when you are done with it. You can fold it once its matched changes are viewed. If something new happens in it, it opens again.

Other changes

Everything else the author changed since your review. Mark each change Viewed as you read it. These marks are separate from All changes.

⚡ Deep review · round changes in this section reviews only these changes. See Tuning Deep review.

Others’ threads

Other reviewers’ open threads on GitHub. Resolved ones are folded. Your own threads that aren’t part of your feedback stay in the All changes view.

On the phone

The Review tab of the phone companion opens the same round view for a PR you reviewed before.